Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key name #7

Merged
merged 1 commit into from Jan 15, 2019
Merged

Fix key name #7

merged 1 commit into from Jan 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2019

dib -> div. That's what the Decoder uses :)

dib -> div
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files           1        1           
  Lines          66       66           
=======================================
  Hits           36       36           
  Misses         30       30
Impacted Files Coverage Δ
src/main/scala/io/circe/spire/SpireCodecs.scala 54.54% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a175ac4...580ab24. Read the comment docs.

@LukaJCB
Copy link
Collaborator

LukaJCB commented Jan 15, 2019

Thanks!
Hopefully this will be better once we fix typelevel/spire#757

@LukaJCB LukaJCB merged commit 9d04e9c into circe:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants