Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple affiliations in Zenodo for CFF 1.3.0+ #386

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexlancaster
Copy link

This is an incomplete draft pull request to partially implement multiple affiliations once the upstream schema change is merged in to CFF v1.3.0 in citation-file-format/citation-file-format#523

This PR:

  • is missing unit tests for the moment
  • overrides the base class in cff_1_x_x/authors/zenodo to create an affiliations: key in .zenodo.json if a list is present, otherwise defaults back to the affiliation key.
  • uses the ror if present, but outputs it as id for Zenodo backend.

* incorporate PR from upstream citation-file-format with scheme updates
  for multiple affiliations

* add new derived author class that supports both multiple affiliations

* translates `ror` into  `id` for .zenodo.json
@alexlancaster
Copy link
Author

alexlancaster commented Feb 18, 2024

I'm thinking that this support should perhaps actually be in the base class ZenodoAuthor (in cff_1_x_x/authors/zenodo )? since it appears that's where new functionality goes even if it's not supported in that particular version of the schema, because the validation would catch it before it would try and use the multiple affiliation output. Is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant