-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FREEZE Option to COPY Command and Explicit Transaction Management for Shard Moves #7687
Draft
m3hm3t
wants to merge
8
commits into
main
Choose a base branch
from
m3hm3t/add-freeze-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3hm3t
changed the title
add freeze, start and end transaction
Add FREEZE Option to COPY Command and Explicit Transaction Management for Shard Moves
Sep 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7687 +/- ##
==========================================
- Coverage 89.70% 88.98% -0.72%
==========================================
Files 283 283
Lines 60510 60539 +29
Branches 7541 7547 +6
==========================================
- Hits 54278 53871 -407
- Misses 4078 4449 +371
- Partials 2154 2219 +65 |
Test commands:
Postgresql logs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a suggested description for your PR based on the issue:
Description
This PR enhances shard moves and splits by adding the
FREEZE
option to theCOPY
command, reducing the need for post-operation vacuuming. To achieve this:FREEZE
option toConstructShardCopyStatement
andLocalCopyToShard
.COPY
operation.COPY
inConnectToRemoteAndStartCopy
to ensure the operation is within the same transaction.ShardCopyDestReceiverShutdown
.