PG17 compatibility: Adjust print_extension_changes function for extra type outputs in PG17 #7761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7761 +/- ##
===============================================
Coverage ? 89.64%
===============================================
Files ? 274
Lines ? 59582
Branches ? 7436
===============================================
Hits ? 53413
Misses ? 4035
Partials ? 2134
|
naisila
force-pushed
the
naisila/pg17_print_extension_changes
branch
from
85b11f9
to
636ba7e
Compare
onurctirtir
approved these changes
Nov 22, 2024
In PG17, Auto-generated array types, multirange types, and relation rowtypes are treated as dependent objects, hence changing the output of the print_extension_changes function. Relevant PG commit: e5bc9454e527b1cba97553531d8d4992892fdeef postgres/postgres@e5bc945 Here we create a table with only the basic extension types in order to avoid printing extra ones for now This can be removed when we drop PG16 support.
naisila
force-pushed
the
naisila/pg17_print_extension_changes
branch
from
636ba7e
to
36fb41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PG17, Auto-generated array types, multirange types, and relation rowtypes
are treated as dependent objects, hence changing the output of the
print_extension_changes function.
Relevant PG commit:
e5bc9454e527b1cba97553531d8d4992892fdeef
postgres/postgres@e5bc945
Here we create a table with only the basic extension types
in order to avoid printing extra ones for now.
This can be removed when we drop PG16 support.
https://github.com/citusdata/citus/actions/runs/11960253650/attempts/1#summary-33343972656
| table pg_dist_local_group | table pg_dist_node | table pg_dist_node_metadata | table pg_dist_partition | table pg_dist_placement | table pg_dist_poolinfo | table pg_dist_rebalance_strategy | table pg_dist_shard | table pg_dist_transaction | type citus.distribution_type + | type citus.distribution_type[] + | type citus.pg_dist_object + | type citus.pg_dist_object[] | type citus.shard_transfer_mode + | type citus.shard_transfer_mode[] | type citus_copy_format + | type citus_copy_format[] + | type citus_dist_stat_activity + | type citus_dist_stat_activity[] + | type citus_lock_waits + | type citus_lock_waits[] + | type citus_shard_indexes_on_worker + | type citus_shard_indexes_on_worker[] + | type citus_shards_on_worker + | type citus_shards_on_worker[] + | type citus_stat_statements + | type citus_stat_statements[] + | type citus_worker_stat_activity + | type citus_worker_stat_activity[] | type noderole + | type noderole[] + | type pg_dist_authinfo + | type pg_dist_authinfo[] + | type pg_dist_colocation + | type pg_dist_colocation[] + | type pg_dist_local_group + | type pg_dist_local_group[] + | type pg_dist_node + | type pg_dist_node[] + | type pg_dist_node_metadata + | type pg_dist_node_metadata[] + | type pg_dist_partition + | type pg_dist_partition[] + | type pg_dist_placement + | type pg_dist_placement[] + | type pg_dist_poolinfo + | type pg_dist_poolinfo[] + | type pg_dist_rebalance_strategy + | type pg_dist_rebalance_strategy[] + | type pg_dist_shard + | type pg_dist_shard[] + | type pg_dist_shard_placement + | type pg_dist_shard_placement[] + | type pg_dist_transaction + | type pg_dist_transaction[] | view citus_dist_stat_activity | view citus_lock_waits | view citus_shard_indexes_on_worker | view citus_shards_on_worker | view citus_stat_statements | view citus_worker_stat_activity | view pg_dist_shard_placement -(186 rows) +(228 rows)