Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect is_required and is_disabled in Field controls. #405

Merged

Conversation

AlexSkrypnyk
Copy link
Contributor

Control is an actual HTML form element or multiple elements that represent the "core" part of the Field.

Field template handles passing own props to controls if the controls do not already have them.

But for is_required and is_disabled this does not happen. This leads to inability to create complex fields with multiple controls passed to the Field.

This fixes the Field control element not respecting existing is_required and is_disabled that exist on control.

@AlexSkrypnyk
Copy link
Contributor Author

The fact that this is missing is an oversight when i was implementing it originally

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexSkrypnyk looks good to me.

@richardgaunt richardgaunt merged commit cc6c585 into civictheme:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers State: Needs more info The issue requires more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants