Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#358] Added default state of collapsed. #415

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

febdao
Copy link
Collaborator

@febdao febdao commented Oct 27, 2024

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added default state of collapsed.

Screenshots

Screenshot 2024-10-27 at 11 22 53 PM

@febdao febdao requested a review from richardgaunt October 27, 2024 16:27
@febdao febdao self-assigned this Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.86%. Comparing base (93fc1c6) to head (e8c2d68).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
components/00-base/collapsible/collapsible.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   13.87%   13.86%   -0.02%     
==========================================
  Files          27       27              
  Lines        1290     1291       +1     
  Branches      307      307              
==========================================
  Hits          179      179              
- Misses        894      895       +1     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request October 27, 2024 16:31 Inactive
@richardgaunt richardgaunt changed the title [CIVIC-1958] Added default state of collapsed. [#358] Added default state of collapsed. Nov 11, 2024
@richardgaunt richardgaunt merged commit 0b44a22 into main Nov 11, 2024
6 of 8 checks passed
@richardgaunt richardgaunt deleted the feature/CIVIC-1958 branch November 11, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants