Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambitions #239

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Ambitions #239

wants to merge 23 commits into from

Conversation

Waschbaerkebab
Copy link

@Waschbaerkebab Waschbaerkebab commented Mar 25, 2020

TODO list

  • Add martial_lady, martial_pagan, martial_tengri (commented out)

  • Add numerous faction-mood-related code (commented out)

  • Add gamerule -> Gender Plus (commented out)

  • Change religion_group = pagan_group back to is_pagan_religion

  • Icons overhaul(?)

  • Refactor some event-triggers for the befriend_liege ambition

  • make namespaces shorter (seems to give an error)


Added adopt_a_lifestyle ambition

Worth to mention:

  • Commented out trait = martial_lady (trait not implemented yet)
  • Commented out trait = martial_lady_pagan (trait not implemented yet)
  • Commented out trait = martial_lady_tengri (trait not implemented yet)

Also commented out:

if = {
     limit = {
          NOR = {
               has_character_modifier = plot_assisted_spying
               has_character_modifier = plot_assisted_spying2
               has_character_modifier = plot_assisted_spying3
               has_character_modifier = plot_assisted_spying4
               has_character_modifier = plot_assisted_spying5
          }
     }
     add_character_modifier = {
     name = plot_assisted_spying
     duration = 90
     }
}

and

liege = { has_law = female_council_law_4 }
[...]
has_game_rule = {
     name = gender
     value = plus
}

I commented out that stuff because I didn't want to add too much stuff outside of the ambitions. If you wish, I'll implement for example the traits, but not any events/decisions to actually receive the trait (which would make it unnecessary to implement the traits yet, but I'm not sure how you want to handle it)

And, as mentioned on discord, changed is_pagan_religion = yes to religion_group = pagan_group, but i mentioned it in the code as comment

From testing, the events and the ambition itself seems to work just fine

@Waschbaerkebab
Copy link
Author

Added following ambitions:

  • amass_wealth_2,
  • amass_wealth_3,
  • amass_wealth_4,
  • be_legitimized

noteworthy:

  • Commented out code that had to do with factions, I'm not familiar with them and they do not seem to be implemented yet. (Seems about recalculating the faction mood for the prosperity faction?)
  • Refactored some event_modifier which have not been implemented up to this point (added a 'plus' in front, so it's more recognizable what's from the mod)
  • Same for certain triggers
  • Only bastard events that had to do with the ambition were implemented. Others, like about making a claim, not.
  • Changed real_father to true_father_even_if_dead, because the scope did not seem to work correctly otherwise. Shouldn't make a difference because the events are anyway only fired if the character has the ambition, which is only available if the true_father is alive.

@schwarherz schwarherz requested a review from Whizzer June 5, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant