-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambitions #239
Open
Waschbaerkebab
wants to merge
23
commits into
ck2plus:master
Choose a base branch
from
Waschbaerkebab:ambitions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ambitions #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added following ambitions:
noteworthy:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list
Add martial_lady, martial_pagan, martial_tengri (commented out)
Add numerous faction-mood-related code (commented out)
Add gamerule -> Gender Plus (commented out)
Change
religion_group = pagan_group
back tois_pagan_religion
Icons overhaul(?)
Refactor some event-triggers for the
befriend_liege
ambitionmake namespaces shorter (seems to give an error)
Added
adopt_a_lifestyle
ambitionWorth to mention:
trait = martial_lady
(trait not implemented yet)trait = martial_lady_pagan
(trait not implemented yet)trait = martial_lady_tengri
(trait not implemented yet)Also commented out:
and
I commented out that stuff because I didn't want to add too much stuff outside of the ambitions. If you wish, I'll implement for example the traits, but not any events/decisions to actually receive the trait (which would make it unnecessary to implement the traits yet, but I'm not sure how you want to handle it)
And, as mentioned on discord, changed
is_pagan_religion = yes
toreligion_group = pagan_group
, but i mentioned it in the code as commentFrom testing, the events and the ambition itself seems to work just fine