Feature/save load subnet map #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feature/cloud (ckabalan#8) * calc for cloud platforms * updates after further testing * remove debugging statements --------- Co-authored-by: Caesar Kabalan <[email protected]> Co-authored-by: Byron Collins <[email protected]> * refactor cloud subnet sizes based on feedback * added missing integrity SRI Hashes * update set_popover_content * Modify description to highlight AWS and Azure capabilities. --------- Co-authored-by: Caesar Kabalan <[email protected]> Co-authored-by: Byron Collins <[email protected]>
* Want to keep Meta Description short for SEO purposes. * Elected to use built-in Bootstrap mode highlighting versus changing the text style * Removed the Usable IPs popovers in favor of tooltips + hyperlink
* No need to increase the config version. That is only for breaking changes. We can assume 'Standard' for all URLs that do not have a mode for backwards compatibility. Incrementing the config version is when we have a breaking change like changing existing key names or other edge cases we can't code around with high confidence. * Changed the modals slightly to include more information and links to documentation.
* Fixed validation pattern for IP addresses in jQuery Validation. It was missing escape characters for the periods so "192.168." was showing as a fully valid address. * Changed the validation error display to be Bootstrap tooltips instead of additional elements that shift the contents of the page. * Added custom tooltip style for validation errors. * Updated jQuery Validation dependencies.
|
@ckabalan is this still being worked on? This would be an awesome feature to have. |
|
I'll take a deep look at this tonight. Thanks for keeping me accountable! |
|
Would be nice to have it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #7
@ckabalan The Json Schema validation might be overkill considering that the path to loading a json locally will likely be generated from the browser and saved locally and therefore valid. If you feel that validation adds value then there are also additional validations that could be added in the future and not just the Json Schema. I believe that the feature is complete enough for MVP.
I've tested the Json schema against various generated json subnet maps including invalid ones. The error messages generated from the AJV library aren't that user-friendly but they do highlight where the issue lies within the Json schema.