Don't store empty repeating subfields #415
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing repeating subfields without any mandatory subfields, if empty values are sent from the form an "empty" item is stored, with all its properties empties:
The changes in
expand_form_composite()
fix the issue on the scheming side, preparing adata_dict
with an empty list for that field:Sadly, on the CKAN side the navl functions drop the field entirely (somewhere along
make_full_schema
andget_all_key_combinations
) and it doesn't get stored as an extra, so it's missing from the resulting dataset dict.@wardi Ideally we would want an empty list in the resulting dataset, but do you think a missing field is an improvement?