Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): stop immediately when retry limited #576

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

homura
Copy link
Collaborator

@homura homura commented Nov 29, 2023

Description

This PR makes the e2e test stop immediately after the retry limited instead of waiting until the timeout

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Nov 29, 2023 7:50am

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #576 (0b8d3c0) into develop (ddb4d5e) will increase coverage by 0.23%.
The diff coverage is 97.05%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
+ Coverage    86.83%   87.07%   +0.23%     
===========================================
  Files          116      116              
  Lines        23434    23453      +19     
  Branches      2347     2379      +32     
===========================================
+ Hits         20350    20422      +72     
+ Misses        3043     2990      -53     
  Partials        41       41              
Files Coverage Δ
packages/utils/src/async/index.ts 98.26% <97.05%> (+0.34%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb4d5e...0b8d3c0. Read the comment docs.

@homura homura merged commit 85f80e9 into develop Nov 29, 2023
9 checks passed
@homura homura deleted the retry-stop-immediately branch November 29, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants