BREAKING CHANGE: disallow p2sh converting by default since risky

[homura]

Description

Fixes #680

Since it is risky, this PR makes a breaking change to disallow p2sh address conversion by default.

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

• Unit test

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
lumos-website	✅ Ready (Inspect)	Visit Preview	Jun 14, 2024 0:44am

[codecov]

Codecov Report

Attention: Patch coverage is 96.77419% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (b370502) to head (b6845ac).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #699      +/-   ##
===========================================
+ Coverage    87.05%   87.21%   +0.16%     
===========================================
  Files          131      131              
  Lines        25241    25302      +61     
  Branches      2736     2804      +68     
===========================================
+ Hits         21973    22068      +95     
+ Misses        3228     3199      -29     
+ Partials        40       35       -5     

Files	Coverage Δ
packages/common-scripts/src/omnilock.ts	91.45% <100.00%> (+0.44%)	⬆️
packages/common-scripts/src/omnilock-bitcoin.ts	95.00% <96.15%> (+9.41%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b370502...b6845ac. Read the comment docs.