Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: work with bundler without extra setting #721

Merged
merged 26 commits into from
Jun 27, 2024
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Jun 27, 2024

Description

Fixes #597

This PR

  • adds a new module @ckb-lumos/crypto to replace the node:crypto
  • replaces Buffer with Uint8Array
  • activates bigint

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit test
  • Manually test

twhy and others added 26 commits May 30, 2024 16:30
feat: add lumos crypto.randomBytes to replace node's
refactor: replace node crypto methods with noble methods
* build: remove webpack config in nextjs example

* feat: add create-react-app example

* build: set GENERATE_SOURCEMAP=false for CRA example

* refactor: create CRA example with pnpm

* chore: remove package-lock.json in CRA example
# Conflicts:
#	.eslintrc.next.js
#	packages/common-scripts/package.json
#	pnpm-lock.yaml
#	website/docs/migrations/migrate-to-v0.24.md
Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Jun 27, 2024 9:26am

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 92.52336% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (d279b87) to head (2a14824).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #721      +/-   ##
===========================================
+ Coverage    87.14%   87.21%   +0.07%     
===========================================
  Files          132      133       +1     
  Lines        25346    25348       +2     
  Branches      2752     2752              
===========================================
+ Hits         22087    22107      +20     
+ Misses        3219     3201      -18     
  Partials        40       40              
Files Coverage Δ
packages/base/src/utils.ts 83.76% <100.00%> (ø)
packages/common-scripts/src/common.ts 89.55% <100.00%> (ø)
packages/crypto/src/index.ts 100.00% <100.00%> (ø)
packages/debugger/src/context.ts 92.51% <100.00%> (-0.04%) ⬇️
packages/debugger/src/executor.ts 97.95% <100.00%> (+0.04%) ⬆️
packages/hd/src/extended_key.ts 97.74% <100.00%> (+0.05%) ⬆️
packages/hd/src/key.ts 96.84% <100.00%> (+0.10%) ⬆️
packages/hd/src/keychain.ts 100.00% <100.00%> (ø)
packages/hd/src/keystore.ts 92.08% <100.00%> (+0.44%) ⬆️
packages/base/src/values.ts 84.28% <0.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d279b87...2a14824. Read the comment docs.

@homura homura requested review from Keith-CY and twhy June 27, 2024 10:27
@homura homura marked this pull request as ready for review June 27, 2024 10:27
@homura homura merged commit 193ba6a into develop Jun 27, 2024
9 checks passed
@homura homura deleted the browser branch June 27, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Lumos Work Smother With the Modern Frontend Dev Tools
3 participants