adding appConfiguration to view.metadata
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keighrim
force-pushed
the
208-configuredAs
branch
from
5dd0038 to
0655172
Compare
There was a problem hiding this comment.
Looks good to me. The only thing I suggest is to change the name to appConfiguration. I like using configuration in the name, but with appConfiguredAs we make it a mini phrase rather than a nominal.
I also remember vaguely a worry that not using refinedParameters would break compatibility.
|
Changed the name. |
keighrim
changed the title
appConfiguredAs to view.metadataappConfiguration to view.metadata
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208