Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to create and edit recipes in the browser #26

Open
wants to merge 42 commits into
base: gh-pages
Choose a base branch
from

Conversation

RobinWeitzel
Copy link

Uses the Github API to commit new or changed recipes to the repository.
This makes it possible to create and edit recipes without having to open a text editor every time.

A few caveats:

  • Unfortunately, Githubs CORS policy on OAuth requests makes it impossible to use OAuth for authentication.
  • After updating a file, it takes a few minutes for Github to rebuild the site so changes are not immediately visible.
  • Does not work with component recipes

@PhilipNelson5
Copy link

what does this caveat mean for usability?

Unfortunately, Githubs CORS policy on OAuth requests makes it impossible to use OAuth for authentication.

@RobinWeitzel
Copy link
Author

It means, you have to log in to Github every time you make an edit. I can't request a token from Github to keep the user logged in (without using a third party service which I want to avoid).

For me personally, I usually only add one recipie at a time so in that case it does not matter but if you want to add multiple recipies right after each other it's extra hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants