-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info tags #31
Open
rathgar
wants to merge
17
commits into
clarklab:gh-pages
Choose a base branch
from
rathgar:meta-info
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Info tags #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cipe adds them to search
# Conflicts: # _includes/nutritional-information.html # _layouts/recipe.html # css/main.scss
Now up-to-date with the latest head |
Include links to relevant index pages
improve top links remove unnecessary logic
Display a message instead of a blank page.
I just had an idea that might improve the semantics of the This would result in a clearer markup in the front matter: courses: [lunch,dinner,snack] Does that sound better? |
now work when pre-built to html
leaves the spacial jeckyll category attribute for something else
Not necessary to capitalise the displayed tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds various tag information supported by Recipe Schema.
Schema elements added are:
These correspond to recipe front matter as:
Thanks to the work by @MichaelThomasMPT
tags
are already searchable. This PR builds on that and integrates them with other recipe meta data.This offers a way to display the information. While it does allow users to search by the terms it still isn't possible to navigate to say, all 'Vegetarian' recipes. Although I do know @clarklab has got plans in this direction with the Books feature. Perhaps the tag labels could link to these books?
I have deliberately conflated
recipeCategory
withcategory
as they seemed semantically equivalent. If there are plans to use this differently, they could be separated.Appearance
Appears below the introduction, above the recipe detail:
Mobile
Desktop