This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
Compatibility with hangfire beta (1.7.0) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiuconstantin
suggested changes
Nov 23, 2018
There was a problem hiding this comment.
- the defaults should stay as they currently are, those describe the most common scenario the library is used
- the /docs folder (used by Github Pages to serve the demo) should be manually updated with the latest app build as this is not done automatically yet (use
npm run docscommand) - when setting
hideSeconds: false, hideYears: falsewe get an error: "Uncaught (in promise): Invalid cron expression, there must be 7 segments" - please double check your changes and ensure no breaking changes are introduced
Olteanu-Mihai
force-pushed
the
master
branch
3 times, most recently
from
57a9177 to
303ffb2
Compare
claudiuconstantin
suggested changes
Nov 28, 2018
| hideSeconds: boolean; | ||
| hideSeconds: boolean; //hides the seconds field in the UI | ||
|
|
||
| removeSeconds: false; // removes seconds from the CRON expression |
There was a problem hiding this comment.
Please make these two members boolean, otherwise you can only assign false to them
| @@ -295,5 +295,8 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div clas="row" *ngIf="!state.validation.isValid"> | |||
There was a problem hiding this comment.
class instead of clas here
| private cronIsValid(cron: string): boolean { | ||
| if (cron) { | ||
| const cronParts = cron.split(" "); | ||
| private cronIsValid(cron: string): void { |
There was a problem hiding this comment.
Please note that this method is called on line 230 and a return value is expected there, therefore void is not appropriate. Decide upon returning a value or not and name the method accordingly
Olteanu-Mihai
force-pushed
the
master
branch
from
303ffb2 to
2a03906
Compare
Olteanu-Mihai
force-pushed
the
master
branch
from
2a03906 to
c4da518
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new option hideYears; the generated cron expression now takes hideSeconds and hideYears into account - i.e. when they are set to true the generated cron will omit seconds and years from the expression, thus making the expression compatible with Hangfire beta