This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Add: shooter_scoreを元にresultへの遷移 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Kizuku
suggested changes
Aug 17, 2024
src/App.tsx
Outdated
| import { Route, Routes } from "react-router-dom"; | ||
| import Home from "./pages/home"; | ||
| import Result from "./pages/result"; | ||
| import Shooter from "./pages/shooter"; | ||
| import Yatai from "./pages/yatai"; | ||
|
|
||
| const AppRoutes = () => { | ||
| const [score, setScore] = useState(0); |
There was a problem hiding this comment.
zustundの方で値を管理するようにしてもらえると
(これだとscoreの値が変わるたびに全体が再レンダリングされてしまうので)
src/pages/result/index.tsx
Outdated
| </div> | ||
| <div className={styles["share-btn"]}> | ||
| <a | ||
| href="https://twitter.com/intent/tweet?text=Webの射的で遊んだよ.%20%23virtualnatsumatsuri%20%23炎上開発%20%23鹿児島ハッカソン" | ||
| href={`https://twitter.com/intent/tweet?text=Webの射的で遊んだよ。${score}本倒した！%20%23virtualnatsumatsuri`} |
There was a problem hiding this comment.
ハックツの夏祭りように改修してるので、
#ハックツ夏祭り
のハッシュハグつけるようにしてもらえると
src/pages/shooter/index.tsx
Outdated
| setScore((prevScore) => prevScore + 1); | ||
| console.log(score); | ||
| const newScore = score + 1; | ||
| setScoreState(newScore); |
There was a problem hiding this comment.
Suggested change
| setScoreState(newScore); | |
| setScoreState((prev) => prev + 1); |
こんな感じで値の更新をしないと正しくstateが更新されない場合があるので、変更お願いします
src/pages/shooter/index.tsx
Outdated
| } | ||
| }); | ||
| }, [onMessage, uuid, score]); | ||
|
|
||
| useEffect(() => { | ||
| if (images.length === 0) { | ||
| setScore(score); |
There was a problem hiding this comment.
これは、images(コルクの残量)が0になったときにresultに遷移する処理です！
K-Kizuku
suggested changes
Aug 18, 2024
K-Kizuku
approved these changes
Aug 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.