This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
ぬるぬる動くようになった #49
Merged
ぬるぬる動くようになった #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse Report
|
Visualizer ReportYou can view the results here. |
Sea10wood
previously approved these changes
Aug 17, 2024
claustra01
suggested changes
Aug 18, 2024
Comment on lines
21
to
37
| // TODO: これらは一人用,いつかマルチプレイヤー対応する | ||
| const [aim, setAim] = useState<Target | undefined>(undefined); | ||
| // TODO: エイム照準の実装 | ||
| // const aimTarget = (data: PointerSchema) => { | ||
| // const x = window.innerWidth * data.target.x + window.innerWidth / 2; | ||
| // const y = window.innerHeight * data.target.y + window.innerHeight / 2; | ||
| // setAim({ x, y }); | ||
| // }; | ||
| const aimTarget = (data: PointerSchema) => { | ||
| const x = window.innerWidth / 2 + data.target.x * 1200; | ||
| const y = window.innerHeight / 2 + data.target.y * 1200; | ||
| setAim({ x, y }); | ||
| }; | ||
|
|
||
| // const [target, setTarget] = useState<Target | undefined>(undefined); | ||
| const shotTarget = (data: ActionSchema) => { | ||
| const x = window.innerWidth / 2 + data.target.x * 1200; | ||
| const y = window.innerHeight / 2 + data.target.y * 1200; | ||
| // TODO: エイム実装ができたらここのsetAimは削除する | ||
| setAim({ x, y }); | ||
| // setTarget({ x, y }); |
There was a problem hiding this comment.
この辺、pointerはaimで、actionはtargetでx,yを保持していようという意図の宣言だったんですけど、よく考えたら別にaimだけで良さそうですね
であれば、aimTargetとshotTargetも統合できるので、不要なコメント群諸々綺麗にして欲しいです
There was a problem hiding this comment.
あーこの使い分け意味あるのかと思ったけど統合していいやつなのね
統合しときます
src/pages/shooter/index.tsx
Outdated
| import style from "./index.module.css"; | ||
|
|
||
| const Shooter = () => { | ||
| const [isOpen, setIsOpen] = useState(true); | ||
| const [score, setScore] = useState<number>(0); |
There was a problem hiding this comment.
このscoreは命中した数のカウント用なんだ！！消さないでくれ🥺🥺
There was a problem hiding this comment.
sea10さんのzustandでのscore管理をマージしたので、そのまま消しておきます
src/pages/shooter/index.tsx
Outdated
Comment on lines
43
to
50
| useEffect(() => { | ||
| onMessage((data) => { | ||
| if (data.message_type === MessageType.Hit && data.id === uuid) { | ||
| setScore((prevScore) => prevScore + 1); | ||
| console.log(score); | ||
| } | ||
| }); | ||
| }, [onMessage, uuid, score]); |
There was a problem hiding this comment.
この辺でtype=hitのwebsocketメッセージを受け取ってスコアをカウントしてる
消さないでくれ🥺🥺
|
deployし直しのためreopen |
claustra01
suggested changes
Aug 18, 2024
src/components/Gallery/index.tsx
Outdated
| ); | ||
|
|
||
| const handleClick = () => { | ||
| resetTargetStatus(); |
There was a problem hiding this comment.
ここでtargetStatusのリセットをしているが、正常な遷移（/result）ではリセットされていないので、ここではなくて（/yatai）の読み込み時にリセットしたい
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.