Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set fgout q_out_vars to default #630

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

rjleveque
Copy link
Member

Should be [h,hu,hv,eta] as in old versions, but now qmap['eta'] varies depending on equations being solved (e.g. geoclaw-bouss or dclaw).

Should be `[h,hu,hv,eta]` as in old versions, but now `qmap['eta']` varies
depending on equations being solved (e.g. `geoclaw-bouss` or `dclaw`).
@mandli
Copy link
Member

mandli commented Oct 22, 2024

I am not sure I am understanding why qmap would not be defined and would require a try-except block. If anything maybe we are expecting an integer in the dictionary?

@rjleveque
Copy link
Member Author

qmap should always be defined but the user might pass in a custom qmap that does not contain eta. Probably not, but I was being extra cautious.

The main change is that qmap['eta'] should be used rather than hardwired to 4.

@mandli
Copy link
Member

mandli commented Oct 29, 2024

Maybe just checking the dictionary for the key eta and throw an exception then?

@rjleveque
Copy link
Member Author

Maybe just checking the dictionary for the key eta and throw an exception then?

Good idea to check for key, I changed it.

@mandli mandli merged commit a492ce7 into clawpack:master Oct 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants