Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Winner #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Winner #30

wants to merge 3 commits into from

Conversation

Ricardo-AlterTable
Copy link

No description provided.

@cleanbrowsing
Copy link
Owner

Love the idea. Mind just switching the text to English? to make it easier for more people to use?
thanks!

dade80vr
dade80vr suggested changes Apr 12, 2018
View reviewed changes
Copy link

@dade80vr dade80vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be use "#!/usr/bin/env bash" instead

@Ricardo-AlterTable
mod winner
6ef0265 
change a English winner
@thomasmerz
Copy link
Contributor

A more current base (#68) should be used as base for this. @cleanbrowsing , I'm willing to add this feature into shellcheck'ed version. Do you agree, @cleanbrowsing + @Ricardo-AlterTable ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dade80vr dade80vr dade80vr requested changes

@reneaicisneros reneaicisneros reneaicisneros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ricardo-AlterTable @cleanbrowsing @thomasmerz @dade80vr @reneaicisneros