Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-ext filesystems #238

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

silkeh
Copy link
Contributor

@silkeh silkeh commented Jul 4, 2020

Calling stat() on some filesystems, like Btrfs,
results in a dev_t with no relation to the backing device(s),
and subsequent failure to detect the root fs.

Add support such filesystems by retrieving the block device from
/proc/self/mounts and working on from there.

Resolves #61, #182 and #193.

Calling stat() on some filesystems, like Btrfs,
results in a dev_t with no relation to the backing device(s),
and subsequent failure to detect the root fs.

Add support such filesystems by retrieving the block device from
`/proc/self/mounts` and working on from there.

Resolves clearlinux#61, clearlinux#182 and clearlinux#193.
@karthikprabhuvinod
Copy link

karthikprabhuvinod commented Jul 17, 2020

@silkeh Out of curiosity, were you trying to use for Solus?

@silkeh
Copy link
Contributor Author

silkeh commented Jul 17, 2020

Yes, I am using this on my Solus install (with an additional patch for the rootflags that I will PR later).

@ElXreno
Copy link

ElXreno commented May 3, 2021

This PR still unreviewed after a long time. Is there a reason for that?

@silkeh
Copy link
Contributor Author

silkeh commented May 4, 2021

This PR still unreviewed after a long time. Is there a reason for that?

My guess is that it has to do with the new direction of the Clear Linux project (which killed off official desktop support). Not sure why the boot manager is also affected by this, but looking at the profiles of @dorileo and @karthikprabhuvinod (and the other clearlinux repos) it seems that Intel stopped sponsoring development somewhere between May and July of 2020.

@ahkok
Copy link
Contributor

ahkok commented Jun 30, 2021

This actually looks really good. I suppose we should run this through our own tests and make sure it works ok. I known @mdhorn might want to do this, or else @phmccarty maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work on Btrfs
5 participants