Add mount-boot command.
#251
Conversation
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=@BINDIR@/clr-boot-manager mount-boot | ||
| ExecStop=@BINDIR@/umount /boot |
There was a problem hiding this comment.
I think clr-boot-manager supports using a different boot directory than /boot, you should replace the /boot here with a template option.
There was a problem hiding this comment.
Goot catch, updated!
| * This file is part of clr-boot-manager. | ||
| * | ||
| * Copyright © 2016-2018 Intel Corporation | ||
| * Copyright © 2020 Silke Hofstra |
There was a problem hiding this comment.
I don't think you can claim copyright on this file.
There was a problem hiding this comment.
Actually, this is entirely reasonable.
When you add a new file, or add code that contains substantial amounts of new code authored by your, adding an author/copyright line is very much okay.
Maybe the date should be changed to 2022, though. Unless it's actually old code that's been circulated before.
There was a problem hiding this comment.
Maybe the date should be changed to 2022, though. Unless it's actually old code that's been circulated before.
Looking at my original commit date, this is correct. It has been ready for a while, pending a go-ahead to start integrating fwupd for solus.
The `mount-boot` command mounts the boot partitions. This is useful for when the user, any system component, requires the boot directory to be mounted. As unmounting afterwards is a simple `umount`, no `unmount-boot` command is added.
This PR adds a
mount-bootcommand and corresponding service. The service can then be depended upon by services that require/bootto be mounted (likefwupd).This allows for integration like discussed in #77.