-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
changed the title
[WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #3)
[WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6)
Oct 11, 2021
Relies on clearmatics/libff#64 |
dtebbs
changed the title
[WIP] Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6)
Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6)
Oct 11, 2021
dtebbs
force-pushed
the
exceptions-fix
branch
from
October 11, 2021 13:41
1a51839
to
d27f9e1
Compare
dtebbs
force-pushed
the
exceptions-fix
branch
from
October 11, 2021 19:34
d27f9e1
to
fbbf6f5
Compare
libfqfft/evaluation_domain/domains/arithmetic_sequence_domain.tcc
Outdated
Show resolved
Hide resolved
libfqfft/evaluation_domain/domains/geometric_sequence_domain.tcc
Outdated
Show resolved
Hide resolved
dtebbs
force-pushed
the
exceptions-fix
branch
from
October 13, 2021 08:50
fbbf6f5
to
4877aed
Compare
3 tasks
AntoineRondelet
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge @HarryR's PR to remove the use of exceptions in domain selection logic: scipr-lab/libfqfft#12
Original branch: https://github.com/Ethsnarks/libfqfft/tree/no-exceptional-control-flow