-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anemoi circuit to run all rounds #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vesselinux
force-pushed
the
104-anemoi-permutation-all-rounds
branch
from
February 3, 2023 13:02
c4cbd74
to
a48ffe6
Compare
Base automatically changed from
82-anemoi-parameters-all-curves
to
anemoi-hash-r1cs
February 3, 2023 14:10
vesselinux
force-pushed
the
104-anemoi-permutation-all-rounds
branch
5 times, most recently
from
February 8, 2023 14:43
0d86695
to
8a6b152
Compare
…ve inside the parameters class; modified the SAGE script accordingly
…est_anemoi_round_prime_field_gadget
…ield_gadget class. it is used to extract the round constants C,D, which arenow removed from the class. removed two unused functions from the same class.
…tput number of r1cs constraints and variables
vesselinux
force-pushed
the
104-anemoi-permutation-all-rounds
branch
from
February 22, 2023 16:53
8a6b152
to
bb2eff3
Compare
dtebbs
reviewed
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just a couple of points related to copying vs referencing the constants.
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.tcc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #104 .