Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bls12 377 gadgets for Groth16 #19

Merged
merged 30 commits into from
Jul 28, 2020
Merged

Bls12 377 gadgets for Groth16 #19

merged 30 commits into from
Jul 28, 2020

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Jul 14, 2020

No description provided.

@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch 4 times, most recently from 67d0914 to 20a777e Compare July 16, 2020 15:59
@dtebbs dtebbs force-pushed the bls12-377-gadgets-final-exp branch 3 times, most recently from 3734567 to 66074c7 Compare July 17, 2020 13:32
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch 3 times, most recently from da8fb60 to afca9c9 Compare July 22, 2020 11:55
@dtebbs dtebbs mentioned this pull request Jul 22, 2020
Merged
dtebbs
dtebbs commented Jul 22, 2020
View reviewed changes
Copy link
Contributor Author

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to address consistency of #ifndef, #ifdef and #if forms.

@dtebbs dtebbs force-pushed the bls12-377-gadgets-final-exp branch 3 times, most recently from eedba35 to e35f386 Compare July 22, 2020 15:32
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch from e9fab87 to 1d99b78 Compare July 23, 2020 12:05
@dtebbs dtebbs force-pushed the bls12-377-gadgets-final-exp branch 2 times, most recently from 108bef3 to 73c3b11 Compare July 23, 2020 13:50
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch from 1d99b78 to 42c7f53 Compare July 23, 2020 13:53
@dtebbs dtebbs changed the title WIP: Bls12 377 gadgets for Groth16 (depends on #18) Bls12 377 gadgets for Groth16 (depends on #18) Jul 23, 2020
@dtebbs dtebbs mentioned this pull request Jul 23, 2020
Merged
AntoineRondelet
AntoineRondelet reviewed Jul 27, 2020
View reviewed changes
libzecale/circuits/aggregator.tcc Outdated Show resolved Hide resolved
libzecale/circuits/groth16_verifier/r1cs_gg_ppzksnark_verifier_gadget.tcc Show resolved Hide resolved
libzecale/circuits/groth16_verifier/r1cs_gg_ppzksnark_verifier_gadget.tcc Show resolved Hide resolved
libzecale/circuits/pairing/bls12_377_pairing.hpp Outdated Show resolved Hide resolved
libzecale/circuits/pairing/bls12_377_pairing.hpp Show resolved Hide resolved
libzecale/circuits/pairing/bls12_377_pairing.tcc
, A(pb, FMT(annotation_prefix, " A"))
, check_A(
pb, in_R.X, in_R.Y, A * FqT(2), FMT(annotation_prefix, " check_A"))
, _A(pb,
Copy link
Contributor

@AntoineRondelet AntoineRondelet Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent on how we build these gadgets here. I most parts of the code base, smart ptrs are used and passed as args before being reset/new'ed in the parent gadget's constructor. This contrasts with the existing code.

To be clear, I am not suggesting to do this as part of this PR, but rather to keep this in mind as further improvement going forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: #23

libzecale/circuits/pairing/bls12_377_pairing.tcc

// B = Ry^2
, B(pb, FMT(annotation_prefix, " B"))
, check_B(pb, in_R.Y, B, FMT(annotation_prefix, " check_B"))
, _B(pb,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another place where #20 would apply.

  • _B ->compute_B (same for the annotation)
  • Ry^2 (the output wire annotation) -> B

Same applies for the other gadgets in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be covered in a later change.

libzecale/serialization/proto_utils.hpp Outdated Show resolved Hide resolved
libzecale/tests/circuits/bls12_377_pairing_test.cpp Outdated Show resolved Hide resolved
libzecale/tests/circuits/miller_loop_gadgets_test.cpp Outdated Show resolved Hide resolved
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch from 993a66a to 3ceb134 Compare July 27, 2020 13:23
@dtebbs dtebbs changed the base branch from bls12-377-gadgets-final-exp to bls12-377-gadgets July 27, 2020 13:23
@AntoineRondelet AntoineRondelet mentioned this pull request Jul 27, 2020
Open
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch from 934a45a to 3e670e3 Compare July 27, 2020 15:21
@dtebbs dtebbs changed the title Bls12 377 gadgets for Groth16 (depends on #18) Bls12 377 gadgets for Groth16 Jul 27, 2020
dtebbs added 26 commits July 28, 2020 10:32
@dtebbs
libzecale: move bw6 pairing params in libzecale namespace to match mnt
f995d27
@dtebbs
libzecale: more generic pairing_circuits_test
c5328c7
@dtebbs
libzecale: bls12_377_G1_precomputation object refactor
815a472
@dtebbs
libzecale: refactor bls12_377 G2 precompute gadgets (incl. dbl/add)
6b0a02d
@dtebbs
libzecale: refactored bls12_377_miller_loop_gadgets
67e98c0
@dtebbs
libzecale: bls12-377 final_exp first and last part gadgets with corre…
cc96286 
…ct form. full pairing test.
@dtebbs
libzecale: bls12-377 precomputation object interfaces
7f679e2
@dtebbs
libzecale: separate miller loop gadget tests from the pairing check t…
a512429 
…ests
@dtebbs
libzecale: bls12_377_e_times_e_times_e_over_e_miller_loop_gadget impl…
f0404a3 
…ementation and tests
@dtebbs
libzecale: apply pairing_circuit_tests to bw6-bls12 chain
3ccbd36
@dtebbs
clean up groth16 tests
d286d57
@dtebbs
libzecale: use protoboard::is_satisfied() in bls12-377 gadget tests f…
d9754f7 
…or better diagnostics
@dtebbs
libzecale: support initialization of bls12-377 precompute gadgets fro…
56bedff 
…m constants
@dtebbs
libzecale: enable groth16_verifier_circuit_test for bw6-761/bls12-377…
8a3b665 
… chain
@dtebbs
aggregator: clean handling of npp and wpp types
ecee017
@dtebbs
Clean build config. Avoid libff CURVE macro and remove hard-coded path.
e6822c0
@dtebbs
libzecale: make aggregator_test generic
5b39670
@dtebbs
libzecale: make proto_utils_test generic over curve and snark
ba0d843
@dtebbs
Remove ZKSNARK macro and use ZECALE_SNARK config variable in applicat…
79b5d2c 
…ions only.

Types describing snark verification gadgets.
Parameterize all code by snark and add test configs.
@dtebbs
libzecale: correct reference to clearmatics version of libff
6332de6
@dtebbs
libzecale: alter annotation in test
24c8206
@dtebbs
libzecale: rename type param in generic miller_loop test
40acea9
@dtebbs
libzecale: remove unused type in aggregator
c6fa7ad
@dtebbs
libzecale: reworded comment in precomputation variables
c498cec
@dtebbs
fix use of new zeth type names
599ddbc
@dtebbs
consistent naming of types and type-parameters
616488b
@dtebbs dtebbs force-pushed the bls12-377-gadgets-groth16 branch from 3e670e3 to 616488b Compare July 28, 2020 09:32
@AntoineRondelet AntoineRondelet merged commit e7f60e4 into bls12-377-gadgets Jul 28, 2020
AntoineRondelet added a commit that referenced this pull request Jul 28, 2020
@AntoineRondelet
Merge pull request #21 from clearmatics/bls12-377-gadgets-update-zeth
ea79d99 
Update zeth (depends on #19)
@AntoineRondelet AntoineRondelet deleted the bls12-377-gadgets-groth16 branch July 30, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet