WIP

clemlesne · Aug 17, 2024 · da48d10 · da48d10
1 parent 95f6012
commit da48d10
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/pipeline.yaml b/.github/workflows/pipeline.yaml
@@ -92,7 +92,7 @@ jobs:
         run: make build
 
       - name: Rename binary (Linux)
-        if: runner.os == 'Ubuntu' || runner.os == 'macOS'
+        if: runner.os == 'Linux' || runner.os == 'macOS'
         run: mv dist/scrape-it-now dist/scrape-it-now-${{ needs.init.outputs.VERSION }}-${{ matrix.os }}
 
       - name: Rename binary (Windows)

diff --git a/Makefile b/Makefile
@@ -85,7 +85,9 @@ dev:
 build:
 	@echo "➡️ Building app..."
 	pyinstaller \
+		--add-data resources:resources \
 		--clean \
+		--icon resources/logo.ico \
 		--name scrape-it-now \
 		--onefile \
 		--optimize 2 \

diff --git a/resources/logo.ico b/resources/logo.ico
diff --git a/resources/logo.png b/resources/logo.png