Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct handling of lookups defined by GET DIRECT LOOKUPS when used as function call arguments #379

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: correct handling of lookups defined by GET DIRECT LOOKUPS when used as function call arguments #379

merged 2 commits into from
Oct 17, 2023

Conversation

ToddFincannonEI
Copy link
Collaborator

@ToddFincannonEI ToddFincannonEI commented Oct 17, 2023 •
edited by chrispcampbell
Loading

Fixes #378

See issue for details.

@ToddFincannonEI ToddFincannonEI changed the title handle lookup functions as special forms on the first argument bug: incorrect code gen using GET DIRECT LOOKUPS lookups (#378) Oct 17, 2023
@chrispcampbell chrispcampbell changed the title bug: incorrect code gen using GET DIRECT LOOKUPS lookups (#378) fix: correct handling of lookups defined by GET DIRECT LOOKUPS when used as function call arguments Oct 17, 2023
chrispcampbell
chrispcampbell approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@chrispcampbell chrispcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a branch that's nearly ready with a ton of unit tests for equation reading and code gen, so I will make sure this is also covered in those tests.

@chrispcampbell chrispcampbell merged commit a032779 into main Oct 17, 2023
3 checks passed
@chrispcampbell chrispcampbell deleted the todd/378-direct-lookups branch October 17, 2023 17:48
@climateinteractive-bot climateinteractive-bot mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispcampbell chrispcampbell chrispcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect code gen using GET DIRECT LOOKUPS lookups
2 participants
@ToddFincannonEI @chrispcampbell