-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable static network configuration via vmware guestinfo #83
base: master
Are you sure you want to change the base?
Conversation
is this patch working ? I try to do the modification but I've got an error : |
Hello, Please make sure that you have the latest cloudbase-init version installed / cloned before trying to We are currently using OpenStack's review workflow for accepting patches, see this workflow: #62 (comment) Thank you, |
Hi Adrian, Thank you for commenting on this issue. Would it be possible to add the information about this OpenStack review workflow that you have adopted somewhere visible in this repository? ie. in the README or by mentioning it in the pull request template ? I would already have followed all steps in this workflow months ago if I had known about it. |
The import should be fixed now. The codebase is on the current version. |
I have submitted the patch as requested. As @twalcari said, this should be documented. Frustrating that it took two and a half months to be notified of this. |
@kimbernator did you see there were some minor lint issues that need fixing before your patch can be merged? https://review.opendev.org/c/x/cloudbase-init/+/829757 |
@kimbernator you able to clean up those two small lint issues? Been wanting to use this patch for awhile |
I no longer work for the employer whose email I used to log into opendev.org, and consequently I don't have a personal or professional need for this change. If someone else wants to make this contribution, they are free to do so. |
Feature will now be provided by #107 . Could you please close this one ? |
Resolves #78
This enables static networking configuration in the vmware guestinfo metadata source. I basically just have it parse the network data using the nocloud network config v1 parser since they follow the same spec.
I'm a bit green to this codebase so please let me know if there's more I need to add for this to have the intended effect.