Fix DB fetching on not found entries #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a GET call to a non-existent object is requested, the server would not return a proper `404` code response. Instead, it returned a `500`, because `.to_dict()` was called upon the not found object directly (which should be `None`). This patch makes sure that `.to_dict()` is only called upon existing DB models, and as a result, it will return a `404` response on not found objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a GET call to a non-existent object is requested, the server would not return a proper
404code response. Instead, it returned a500, because.to_dict()was called upon the not found object directly (which should beNone). This patch makes sure that.to_dict()is only called upon existing DB models, and as a result, it will return a404response on not found objects.