Fix Windows static IP configuration #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the Windows static IP migration configuration by skipping detected dynamic IP addresses instead of directly raising an error.
panigrap
reviewed
Oct 8, 2024
| {'ip_address': mock.sentinel.ip_address} | ||
| ] | ||
| # no IP addresses on NIC | ||
| {"ip_addresses": [], "mac_address": "00:50:56:92:91:42"}, |
There was a problem hiding this comment.
The values, "00:50:56:92:91:" , ""fe81::728a:688:1a92:baec" .. etc .. can be defined as constants and can be referenced here. As we are using them multiple times.
|
tested successfully |
Dany9966
force-pushed
the
windows-static-ip-fix
branch
from
7ae008a to
bac9bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Windows static IP migration configuration by skipping detected dynamic IP addresses instead of directly raising an error.