Skip to content

Commit

Permalink
commit suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
maigl committed Nov 22, 2024
1 parent 935c9dc commit d6de596
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions database/sql/jobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package sql
import (
"context"
"encoding/json"
"fmt"
"log/slog"

"github.com/google/uuid"
Expand Down Expand Up @@ -247,7 +246,7 @@ func (s *sqlDatabase) CreateOrUpdateJob(ctx context.Context, job params.Job) (pa
workflowJob.InstanceID = &instance.ID
} else {
// This usually is very normal as not all jobs run on our runners.
slog.DebugContext(ctx, fmt.Sprintf("failed to get instance by name: %s", job.RunnerName))
slog.DebugContext(ctx, "failed to get instance by name", "instance_name", job.RunnerName)
}
}

Expand Down
3 changes: 1 addition & 2 deletions runner/pool/pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,7 @@ func (r *basePoolManager) HandleWorkflowJob(job params.WorkflowJob) error {
// we see events where the lables seem to be missing. We should ignore these
// as we can't know if we should handle them or not.
if len(job.WorkflowJob.Labels) == 0 {
slog.WarnContext(
r.ctx, fmt.Sprintf("job has no labels: %s", job.WorkflowJob.Name))
slog.WarnContext(r.ctx, "job has no labels", "workflow_job", job.WorkflowJob.Name)
return nil
}

Expand Down

0 comments on commit d6de596

Please sign in to comment.