Update YamlDotNet assemblies to 13.0, add support for pwsh 7.x #97
Conversation
|
Hi @Eggdale ! This is awesome! Thank you! I have a couple of questions. Where did you download the DLLs from? Which build? The current release (https://github.com/aaubry/YamlDotNet/releases/tag/v13.0.0), lists aaubry/YamlDotNet#771 as the PR which merged last into this release. This corresponds to this build: https://ci.appveyor.com/project/aaubry/yamldotnet/builds/46071641/artifacts. The sha256sum from the above build with the ones in your branch, seem to differ. Thanks again for taking the time to make these changes! |
|
Interesting, I pulled them out of the nuget package from nuget package repository. I assumed those would be the same as the release package but they're not. Even the nuget package on the appveyor site has different binaries. I've added a commit to use the release versions instead of those nuget versions. Thanks! |
|
Hi @Eggdale ! The ones in your commit have the following sha256 sums: gabriel@arrakis:/tmp/powershell-yaml$ git remote -v
origin https://github.com/Eggdale/powershell-yaml.git (fetch)
origin https://github.com/Eggdale/powershell-yaml.git (push)
gabriel@arrakis:/tmp/powershell-yaml$ git log -n 1
commit 3937fea6aa762336ea9ce23038a4b82e0f0aa92f (HEAD -> master, origin/master, origin/HEAD)
Author: Eggdale <[email protected]>
Date: Thu Feb 9 18:56:06 2023 -0600
Updated YamlDotNet to release version
gabriel@arrakis:/tmp/powershell-yaml$ sha256sum lib/*/YamlDotNet.dll
94f4ccbb6ea28cfb10fcfa3aa13109e4c7b3efd6aa42f55dae6e0f8fb55914b7 lib/net35/YamlDotNet.dll
9af8026704a0f7f15491fccea4e1e3aee84ec7d22cdf361ba3395b1109968960 lib/net45/YamlDotNet.dll
9623827afa09c0f504282088bccf929ec92b5ff425515e2e5740599829493850 lib/netstandard2.1/YamlDotNet.dllThe ones from https://ci.appveyor.com/project/aaubry/yamldotnet/builds/46071641/artifacts have the following sha256 sums: gabriel@arrakis:/tmp/tmp.rvk8YB3oeC$ wget -q -O YamlDotNet.13.0.0.zip https://ci.appveyor.com/api/buildjobs/h62oyyp2v4icscna/artifacts/YamlDotNet%2Fbin%2FYamlDotNet.13.0.0.nupkg
gabriel@arrakis:/tmp/tmp.rvk8YB3oeC$ unzip -q YamlDotNet.13.0.0.zip
gabriel@arrakis:/tmp/tmp.rvk8YB3oeC$ sha256sum lib/{netstandard2.1,net35,net45}/YamlDotNet.dll
c24933cb18f83e97fcae76c4baa6909964bea4b88906bff3cd4bb5e923da469a lib/netstandard2.1/YamlDotNet.dll
183f985548d83691e5dba0670a38d13f07f5f838ed90a71b3f7516ebebcef05d lib/net35/YamlDotNet.dll
321b606038c1b447977a996f8c77ea9c9b7cb20fd8eaf9232e9d9ca9dc24d2fa lib/net45/YamlDotNet.dllSorry to nitpick, I just want to make sure we get the right version in. |
|
No worries, thanks for keeping me honest! Should I use a different build, or is this one sufficient? Sorry for the confusion, still very green when it comes to open source contributions. |
No worries at all! We've all started somewhere 😄. In general, when dealing with binary blobs, it's important to state the exact location where they were downloaded from and versions. This helps trust and allows anyone that wants to use this project to verify the binaries for themselves before using it on production systems. In general, anything that is not code that can be audited, must be verifiable. When it comes to projects that have wide usage (approximately 1.2 mil downloads/month in this case), we must be extra careful and transparent 🙂 . That being said, let's use the binaries from the latest stable release, which seems to be this one: https://ci.appveyor.com/project/aaubry/yamldotnet/builds/46071641/artifacts (version: 13.0.0.944). |
|
Thanks for the guidance, I've updated the binaries accordingly. Thanks! |
|
One last thing, which I should have noticed earlier. While the dlls are built from an open source and free project, we are still obliged to acknowledge where we got them from and distribute them with their license included in each folder ( https://github.com/aaubry/YamlDotNet/blob/master/LICENSE.txt Sorry I didn't catch it earlier, and thanks for your patience 😄. |
|
Gotcha, makes sense. I didn't see them with the releases in the new version so I wasn't sure whether or not to include them manually. Thanks! |
They are not usually included in the binary builds. If we're simply consuming them for our needs, we don't really need to keep the license text with the binaries, but we're redistributing them in our own project, so we have to do that. Thanks for taking the time to contribute these changes! |
Howdy,
I've updated the internal YamlDotNet assemblies to 13.0 to fix #84, which allows for fixing #32 by adding the
WithIndentedSequencesoption toConvertTo-Yaml.TheYamlDotNet.Serialization.SerializationOptionsenum was removed in this YamlDotNet issue, so I added it back locally.Additionally, I've added a fix for pwsh 7.x which would prevent the tests from running due to pwsh not automatically loading standard references when those are loaded manually. see here for details.
Thanks!