Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for coriolisclient main modules #89

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Cristi1324
Copy link
Contributor

This PR adds unit tests for coriolisclient main modules.

@@ -135,9 +135,6 @@ def get(self):
def __eq__(self, other):
if not isinstance(other, Resource):
return NotImplemented
# two resources of different types are not equal
if not isinstance(other, self.__class__):
return False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this code back. This equality is important when comparing resources of different types. (ex. Replica and Migration, these will not be equal, even if their info are the same).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add this case when testing this method.

@Cristi1324 Cristi1324 force-pushed the add_unit_tests branch 3 times, most recently from 1d9cc4f to a930963 Compare November 26, 2024 11:57
@@ -3,17 +3,487 @@

"""Defines base class for all tests."""

from oslotest import base
from oslotest import mock_fixture
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this import into the group below

@Dany9966 Dany9966 merged commit dd1ea31 into cloudbase:master Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants