Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update module _example to Allow traffic from vpc-cidr in nacl attached to private subnets #73

Merged
merged 2 commits into from
May 5, 2024
Merged

update module _example to Allow traffic from vpc-cidr in nacl attached to private subnets #73

merged 2 commits into from
May 5, 2024

Conversation

h1manshu98
Copy link
Member

what

  • Update module _example to show how NACL rules can be updated and yet required to allow traffic from VPC_CIDR.
  • Previously NACL rules were blocking all traffic from anywhere to Private-Subnets that was causing connectivity of Private resources withing the network.

@h1manshu98 h1manshu98 requested a review from a team January 17, 2024 18:35
@clouddrove-ci clouddrove-ci self-assigned this Jan 17, 2024
@h1manshu98 h1manshu98 requested a review from 13archit January 17, 2024 18:44
@h1manshu98 h1manshu98 self-assigned this Jan 17, 2024
@h1manshu98 h1manshu98 added the enhancement New feature or request label Jan 17, 2024
13archit
13archit previously approved these changes Jan 17, 2024
View reviewed changes
theprashantyadav
theprashantyadav previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@theprashantyadav theprashantyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

themaniskshah
themaniskshah previously approved these changes Jan 23, 2024
View reviewed changes
13archit
13archit approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

theprashantyadav
theprashantyadav approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@theprashantyadav theprashantyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 46c2f90 into master May 5, 2024
27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/nacl-example branch May 5, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13archit 13archit 13archit approved these changes

@theprashantyadav theprashantyadav theprashantyadav approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@h1manshu98 h1manshu98

@clouddrove-ci clouddrove-ci

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@h1manshu98 @themaniskshah @theprashantyadav @13archit @clouddrove-ci