Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks, workflow, and instructions #188

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Jun 26, 2024

No description provided.

@wmudge wmudge added the enhancement New feature or request label Jun 26, 2024
@wmudge wmudge added this to the Release 2.5.0 milestone Jun 26, 2024
@wmudge wmudge requested review from asdaraujo and a team and removed request for asdaraujo June 26, 2024 21:07
@wmudge
Copy link
Member Author

wmudge commented Jun 26, 2024

The newly migrated roles (the RDBMS ones) are failing on the Galaxy import. I don't think they have READMEs as required by Galaxy.

@wmudge
Copy link
Member Author

wmudge commented Aug 21, 2024

The rdbms/server role has a dependency on cloudera.cluster.infrastructure.ca_common. However, this collection is not part of the collection's dependencies.

wmudge added 2 commits August 21, 2024 17:09
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 996e8dc into cloudera-labs:devel Aug 22, 2024
7 checks passed
@wmudge wmudge deleted the feature/pre-commit branch August 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validated
Development

Successfully merging this pull request may close these issues.

2 participants