Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with instructions for local environment setup #26

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

balazsgaspar
Copy link
Contributor

Added end-to-end example for local environment setup

@balazsgaspar balazsgaspar requested a review from jimright August 23, 2023 14:10
@jimright jimright requested a review from wmudge August 23, 2023 15:46
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we split this out into a separate file, like DEVELOPMENT.md.

@jimright
Copy link
Contributor

@balazsgaspar, @wmudge - I've moved the instructions for local development to a DEVELOPMENT.md.
If you are happy with that change I will merged

@balazsgaspar
Copy link
Contributor Author

@jimright I am ok with moving this to a separate file, just make sure we link to it from the README.md

Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@jimright jimright merged commit 2320845 into main Sep 19, 2023
3 checks passed
@jimright jimright deleted the end2end_examples branch September 19, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants