Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPC Endpoint fixes #34

Merged
merged 3 commits into from
Oct 4, 2023
Merged

VPC Endpoint fixes #34

merged 3 commits into from
Oct 4, 2023

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Sep 28, 2023 •
edited
Loading

  • Add condition so that vpc endpoints not created when create_vpc is false
  • Remove S3-Global Interface endpoint

@jimright jimright added the bug Something isn't working label Sep 28, 2023
@jimright jimright marked this pull request as ready for review October 4, 2023 11:08
@jimright
Copy link
Contributor Author

jimright commented Oct 4, 2023

Worked with Abhishek in QE team that these changes resolve VPC endpoint issues. Merging.

@jimright jimright merged commit 824cf5c into cloudera-labs:main Oct 4, 2023
3 checks passed
@jimright jimright mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jimright