-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to support provisioning of Azure Files NFS for CML at runtime #39
Feature to support provisioning of Azure Files NFS for CML at runtime #39
Conversation
Plan
|
Apply
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tush4hworks,
Thanks for this. Please see review comments for some changes in line with our conversation.
Thanks,
Jim
modules/terraform-azure-nfs/examples/ex01-nfs_fileshare/.terraform-docs.yaml
Outdated
Show resolved
Hide resolved
modules/terraform-azure-nfs/main.tf
Outdated
} | ||
|
||
|
||
resource "azurerm_linux_virtual_machine" "nfs_vm" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to create a create_vm bool input variable to control the creation of the VM.
Use the variable with e.g. count = var.create_vm ? 1 : 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will think about this later, didn't add it now because we need VM creation always.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tush4hworks - I would like to incorporate the variable, even with default value of true. We can work together on this to get it into this PR.
As the VM is potentially short-lived and only used for a single purpose of performing a chown
on the nfs directory it should be optional.
modules/terraform-azure-nfs/examples/ex01-nfs_fileshare/variables.tf
Outdated
Show resolved
Hide resolved
|
NFS is mounted on the VM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approved.
7bfbb19
to
cebee8c
Compare
See detailed explanation in README.md Provisions a storage account with Premium Tier and Disabled Https traffic only. Creates a NFS file share of 100 GB in the storage account Creates a private dns zone of type privatelink.file.core.windows.net Creates a VNET link between CDP workload VNET and private DNS zone Creates a private endpoint for NFS Storage Account (File sub-resource) for one of the subnets in the CDP VNET - this should be extended to all subnets for CML. Creates a public IP , security group allowing port 22 from everywhere Creates a ubuntu VM with public IP, security group in the CDP VNET to which private endpoint was created. Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
…d conditional provisioning of VM Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
Signed-off-by: tsharma <[email protected]>
4f0f0ed
to
10fa910
Compare
See detailed explanation in README.md
Provisions a storage account with Premium Tier and Disabled Https traffic only. Creates a NFS file share of 100 GB in the storage account Creates a private dns zone of type privatelink.file.core.windows.net Creates a VNET link between CDP workload VNET and private DNS zone Creates a private endpoint for NFS Storage Account (File sub-resource) for one of the subnets in the CDP VNET - this should be extended to all subnets for CML. Creates a public IP , security group allowing port 22 from everywhere Creates a ubuntu VM with public IP, security group in the CDP VNET to which private endpoint was created.