[CYB-201] [UI][COMPONENT] Fix Karma unit test. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added multi choose button implementation. * Added custom palette. * Refactor styles and theming.
* Fixed unit test errors.
* Fixed all unit test errors.
* Add github hook for angular test.
vpavlenko-cv
changed the title
* Update hook.
* Chrome headless browser
* Some fix for maven build.
* Fix swagger update to v3.
* Update node version and dependency graph tool.
# Conflicts: # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/angular.json # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/package-lock.json # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/package.json # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/chain-page.module.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/custom-form/components/multi-input/multi-input.component.spec.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/indexing-form/indexing-form.component.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/live-view/diff-popup/diff-popup.component.html # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/live-view/live-view.module.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/live-view/sample-data-form/sample-data-text-folder-input/sample-data-text-folder-input.component.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/live-view/text-diff-view/text-diff-view.component.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/parser/advanced-editor/advanced-editor.component.spec.ts # flink-cyber/metron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/app/chain-page/components/parser/parser.component.spec.ts
* Fixed merge-conflict.
* Fixed build action.
* Fixed build action.
* Rollback node version to angular compatible.
* Fixed console error.
* Fixed eslint and remove tslint.
* Fixed some test and lint problems.
* Fixed issue with loops.
* Fixed createEffect that did not fire a new action as a result. * Added change detector for multi-iput.
* Fixed type mismatching between component. * Removed redundant effect. * Fixed Eslint naming convention.
* Updated unit tests.
* Remove unnecessary pipe.
stas-panasiuk
requested changes
Apr 18, 2024
flink-cyber/flink-cyber-api/src/main/java/com/cloudera/cyber/indexing/MappingColumnDto.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/cloudera/parserchains/queryservice/controller/ParserController.java
Outdated
Show resolved
Hide resolved
...etron-parser-chain/parser-chains-config-service/frontend/parser-chains-client/src/theme.scss
Outdated
Show resolved
Hide resolved
...rser-chain/parser-chains-config-service/frontend/parser-chains-client/src/custom-palite.scss
Outdated
Show resolved
Hide resolved
...g-service/frontend/parser-chains-client/src/app/chain-list-page/chain-list-page.component.ts
Outdated
Show resolved
Hide resolved
...ice/frontend/parser-chains-client/src/app/chain-page/components/parser/parser.component.html
Show resolved
Hide resolved
...service/frontend/parser-chains-client/src/app/cluster/cluster-page/cluster-page.component.ts
Outdated
Show resolved
Hide resolved
flink-cyber/flink-profiler/pom.xml
Outdated
Comment on lines
50
to
53
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Why do we need guava here?
Comment on lines
72
to
81
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>${jackson.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>${guava.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
do we need new dependencies here?
Fixed PR comments.
Fixed PR comments.
|
Updating all pom files is required, because otherwise it uses transient dependencies from other mvn packages, which is not good, especially when they are marked as provided. |
stas-panasiuk
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.