-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/log
v3 when using composer
#541
base: master
Are you sure you want to change the base?
Conversation
Would be great to get this reviewed/approved! We had a few hundred sites go down today updating Cloudflare via Composer thanks to this fun error 😅 (still trying to figure out why the error didn't show itself in staging) |
@JulienMelissas If you are a business customer of Cloudflare, don't hesitate to open an internal ticket in their support area. If so, feel free to reference our ticket 3130507. |
@aseure @jacobbednarz @william-woodhead Any possible feedback? |
@aseure @jacobbednarz @william-woodhead any update? I've got a pile of duct tape getting our composer based project to work with this plugin specifically being the issue. What's holding it up? |
@aseure @jacobbednarz @william-woodhead any update? |
Alternative solution for #539.
This helps to work around the issue regarding the conflicted dependencies (specifically
Psr\Log
package).This would allow installing the package on a PHP 8 server via Composer, while keeping the wp.org plugin a PHP 7.x target.
Note
This change requires the plugin to be published as a standard package on Packagist and then be released with a new tag.
https://packagist.org/packages/submit
Warning
A conditional class definition is unfortunately required to match
psr/log
methods signatures.This is not very pretty, but, again, required.
b6e81b9
cc @Korben00