minor cleanup #23

peopledrivemecrazy · 2021-10-09T17:52:23Z

cleanup readme

await wallet1.sendTransaction({
    to: addressToFund,
    value: ethers.utils.parseEther("10.0") // 
  })

ethers.utils.parseEther("10.0") will return undefined, the correct way is hre.ethers.utils.parseEther("10.0")

kristianfreeman

Main code change looks good! Unsure if we should add the README part due to my comment - @jkup what do you think?

kristianfreeman · 2021-10-14T18:50:44Z

contract/README.md

@@ -10,6 +10,9 @@ npx hardhat compile
 npx hardhat clean
 npx hardhat test
 npx hardhat node
-node scripts/sample-script.js
+node scripts/test/sample-test.js


It's good for people to know these exist! They aren't very well-documented though - I used them while I was developing this 🤔

minor cleanup

9e4f337

jkup self-requested a review October 13, 2021 19:04

kristianfreeman reviewed Oct 14, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minor cleanup #23

minor cleanup #23

peopledrivemecrazy commented Oct 9, 2021

kristianfreeman left a comment

kristianfreeman Oct 14, 2021

minor cleanup #23

Are you sure you want to change the base?

minor cleanup #23

Conversation

peopledrivemecrazy commented Oct 9, 2021

kristianfreeman left a comment

Choose a reason for hiding this comment

kristianfreeman Oct 14, 2021

Choose a reason for hiding this comment