Use RELEASE_NOTES date instead of build date #1289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think for this repo, we update the RELEASE_NOTES file with every release, so if you are looking for a stable timestamp to reference for the build date, it would be better to use that file. How does that sound? |
to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This date call only works with GNU date and BSD date. This patch was done while working on reproducible builds for openSUSE, sponsored by the NLnet NGI0 fund.
|
updated the commit |
kornelski
approved these changes
Aug 22, 2024
DevinCarr
changed the title
DevinCarr
changed the title
DevinCarr
approved these changes
Aug 22, 2024
|
So is something missing or is it good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
RELEASE_NOTESdate instead of build dateto make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call only works with GNU date and BSD date.
Alternatively, https://reproducible-builds.org/docs/source-date-epoch/#makefile could be implemented.
This patch was done while working on reproducible builds for openSUSE, sponsored by the NLnet NGI0 fund.