C3: Bump node version in e2e tests

cloudflare · Aug 30, 2023 · 8855aad · 8855aad
1 parent 4b60277
commit 8855aad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/test-c3.yml b/.github/workflows/test-c3.yml
@@ -6,7 +6,7 @@ on:
       - packages/create-cloudflare/**
 
 env:
-  node-version: 16.14
+  node-version: 18.17.1
 
 jobs:
   check:

diff --git a/packages/create-cloudflare/e2e-tests/pages.test.ts b/packages/create-cloudflare/e2e-tests/pages.test.ts
@@ -14,6 +14,8 @@ Areas for future improvement:
 - Add support for frameworks with global installs (like docusaurus, gatsby, etc)
 */
 
+const TEST_TIMEOUT = 1000 * 60 * 3;
+
 type FrameworkTestConfig = RunnerConfig & {
 	expectResponseToContain: string;
 	testCommitMessage: boolean;
@@ -234,7 +236,7 @@ describe.concurrent(`E2E: Web frameworks`, () => {
 					frameworkTests[framework].testCommitMessage
 				);
 			},
-			{ retry: 3, timeout: 1000 * 60 * 3 }
+			{ retry: 3, timeout: TEST_TIMEOUT }
 		);
 	});
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,7 @@ on: @@
           - packages/create-cloudflare/**
     env:
-      node-version: 16.14
+      node-version: 18.17.1
     jobs:
       check:
@@ Expand Down @@