Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning wrangler create vector comment to d1 style #5706

Closed
wants to merge 1 commit into from

Conversation

charl-kruger
Copy link
Contributor

Just aligning wrangler output comments for better devX

[[d1_databases]]
binding = "DB" # i.e. available in your Worker on env.DB ..

vs

[[vectorize]]
binding = "VECTORIZE_INDEX" # available within your Worker on env.VECTORIZE_INDEX index_name = "metrics-index"

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

Just aligning wrangler output comments for better devX

[[d1_databases]]
binding = "DB" # i.e. available in your Worker on env.DB
..

vs

[[vectorize]]
binding = "VECTORIZE_INDEX" # available within your Worker on env.VECTORIZE_INDEX
index_name = "metrics-index"
@charl-kruger charl-kruger requested a review from a team as a code owner April 24, 2024 20:29
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 9b05156

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@charl-kruger
Copy link
Contributor Author

Should probably make them both "within" but "in" is fine i think

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-wrangler-5706

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5706/npm-package-wrangler-5706

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-wrangler-5706 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-create-cloudflare-5706 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-cloudflare-kv-asset-handler-5706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-miniflare-5706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-cloudflare-pages-shared-5706
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8822907089/npm-package-cloudflare-vitest-pool-workers-5706

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant