-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix headers in wfp dev #6904
Fix headers in wfp dev #6904
Conversation
|
84a1d8b
to
452873a
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-wrangler-6904 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6904/npm-package-wrangler-6904 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-wrangler-6904 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-create-cloudflare-6904 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-cloudflare-kv-asset-handler-6904 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-miniflare-6904 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-cloudflare-pages-shared-6904 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11206851323/npm-package-cloudflare-vitest-pool-workers-6904 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
dbf87ae
to
79ee9d7
Compare
79ee9d7
to
4a33b78
Compare
@@ -98,7 +107,7 @@ describe("external-dispatch-namespace-app", () => { | |||
`"p2"` | |||
); | |||
expect(await dispatcherResponse.text()).toMatchInlineSnapshot( | |||
`"intercepted"` | |||
`"{\"accept\":\"*/*\",\"accept-encoding\":\"br, gzip\",\"accept-language\":\"*\",\"host\":\"localhost:${outbound.port}\",\"sec-fetch-mode\":\"cors\",\"user-agent\":\"undici\",\"x-foo\":\"bar\"}"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if host
here should be preserved or overwritten. Need to check what prod runtime behavior is.
What this PR solves / how to test
Fixes CUSTESC-45403.
Author has addressed the following