import unenv-preset #7370

vicb · 2024-11-27T15:31:40Z

@pi0 @petebacondarwin This PR imports & sync the cloudflare preset.

#7366 lists (most of) the tasks that will need to be done.

--

imported from https://github.com/pi0/unenv-preset-cloudflare
- sync'd with unjs/unenv at d9d4d03
- added back the .cjs to fix the build

Smoke tested with https://github.com/cloudflare/workers-sdk/tree/preset-test. In that branche, wrangler uses @cloudflare/unenv-preset and the hybrid test pass.

Next steps:

Add a way to test the dev version of the package (the plugin should resolve modules to the workspace version of the file)
Add tests
Setup the NPM release
... see tracking issue

--

@pi0 I changed the license to MIT + Apache, is that ok with you?

@petebacondarwin do you think it would cause an issue to merge this before all of #7366 is done?

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: will be added in a follow up PR
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: newly created pkg not used yet
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: there is no user facing change

changeset-bot · 2024-11-27T15:31:44Z

⚠️ No Changeset found

Latest commit: da6fe7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pi0 · 2024-11-27T15:53:27Z

packages/unenv-preset/build.config.ts

while personally recommand unbuild/mkdist, also a simple tsc would work if it is widely used in this repo.

pi0 · 2024-11-27T15:53:56Z

packages/unenv-preset/eslint.config.mjs

Do you have any other convention perhaps here?

github-actions · 2024-11-27T16:09:52Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-wrangler-7370

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7370/npm-package-wrangler-7370

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-wrangler-7370 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-create-cloudflare-7370 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-kv-asset-handler-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-miniflare-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-pages-shared-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-vitest-pool-workers-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-workers-editor-shared-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-workers-shared-7370

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12278048534/npm-package-cloudflare-workflows-shared-7370

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241205.0
`workerd`	1.20241205.0	1.20241205.0
`workerd --version`	1.20241205.0	2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

pi0 · 2024-11-28T16:27:22Z

@vicb I think you need to update deps.ts to include this new package.

vicb · 2024-11-29T07:12:15Z

@vicb I think you need to update deps.ts to include this new package.

Good point, thanks @pi0. I'll add that to the tracking issue for when we switch wrangler to using this package.

.gitignore

packages/unenv-preset/package.json

packages/unenv-preset/src/index.ts

packages/unenv-preset/src/runtime/node/async_hooks/$cloudflare.ts

petebacondarwin

Will need to update findPackageNames() in validate-changesets.test.ts.

packages/unenv-preset/build.config.ts

packages/unenv-preset/src/index.ts

packages/unenv-preset/turbo.json

petebacondarwin · 2024-12-11T17:15:59Z

Still need to fix this test:

Will need to update findPackageNames() in validate-changesets.test.ts.

petebacondarwin · 2024-12-11T17:16:24Z

And appears to be a problem with the lockfile?

sync at unjs/unenv d9d4d03 https://github.com/pi0/unenv-preset-cloudflare Co-authored-by: Pooya Parsa <[email protected]>

petebacondarwin · 2024-12-11T18:56:36Z

packages/unenv-preset/package.json

+		"workerd": {
+			"optional": true
+		}
+	}


If you add this here:

Suggested change

}

},

"workers-sdk": {

"prerelease": true

}

Then we should auto-generate pre-release builds per PR.

petebacondarwin · 2024-12-11T19:03:50Z

I think to do the first deployment we need to mark it as public access:

npm publish --access public

vicb requested a review from a team as a code owner November 27, 2024 15:31

vicb force-pushed the unenv branch from 7195b77 to 49e9e81 Compare November 27, 2024 15:34

vicb requested a review from petebacondarwin November 27, 2024 15:34

vicb added the e2e Run e2e tests on a PR label Nov 27, 2024

pi0 reviewed Nov 27, 2024

View reviewed changes

packages/unenv-preset/build.config.ts

Copy link

pi0 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while personally recommand unbuild/mkdist, also a simple tsc would work if it is widely used in this repo.

pi0 reviewed Nov 27, 2024

View reviewed changes

packages/unenv-preset/eslint.config.mjs Outdated

Copy link

pi0 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any other convention perhaps here?

vicb added the no-changeset-required label Nov 28, 2024

pi0 mentioned this pull request Dec 2, 2024

Moving cloudflare (hybrid node compat) to external preset unjs/unenv#336

Closed

anonrig reviewed Dec 2, 2024

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

packages/unenv-preset/package.json Show resolved Hide resolved

vicb force-pushed the unenv branch 6 times, most recently from 08eea47 to 708af56 Compare December 11, 2024 09:39

vicb requested a review from pi0 December 11, 2024 13:58

vicb removed the e2e Run e2e tests on a PR label Dec 11, 2024

vicb force-pushed the unenv branch 2 times, most recently from 0195bfd to 81019e0 Compare December 11, 2024 14:11

pi0 reviewed Dec 11, 2024

View reviewed changes

packages/unenv-preset/src/index.ts Outdated Show resolved Hide resolved

packages/unenv-preset/src/runtime/node/async_hooks/$cloudflare.ts Outdated Show resolved Hide resolved

vicb mentioned this pull request Dec 11, 2024

🚀 Feature Request: Import the unenv preset for cloudflare #7366

Open

11 tasks

vicb requested a review from pi0 December 11, 2024 14:25

petebacondarwin reviewed Dec 11, 2024

View reviewed changes

packages/unenv-preset/build.config.ts Outdated Show resolved Hide resolved

packages/unenv-preset/src/index.ts Outdated Show resolved Hide resolved

vicb force-pushed the unenv branch from 81019e0 to 77380ea Compare December 11, 2024 16:34

petebacondarwin approved these changes Dec 11, 2024

View reviewed changes

packages/unenv-preset/turbo.json Show resolved Hide resolved

feat(unenv-preset): import the package

da6fe7f

sync at unjs/unenv d9d4d03 https://github.com/pi0/unenv-preset-cloudflare Co-authored-by: Pooya Parsa <[email protected]>

vicb force-pushed the unenv branch from 2e1a0ea to da6fe7f Compare December 11, 2024 17:46

petebacondarwin reviewed Dec 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import unenv-preset #7370

import unenv-preset #7370

vicb commented Nov 27, 2024 •

edited

Loading

changeset-bot bot commented Nov 27, 2024 •

edited

Loading

pi0 Nov 27, 2024

pi0 Nov 27, 2024

github-actions bot commented Nov 27, 2024 •

edited

Loading

pi0 commented Nov 28, 2024

vicb commented Nov 29, 2024

petebacondarwin left a comment

petebacondarwin commented Dec 11, 2024

petebacondarwin commented Dec 11, 2024

petebacondarwin Dec 11, 2024

petebacondarwin commented Dec 11, 2024

-	}
+	},
+	"workers-sdk": {
+		"prerelease": true
+	}

import unenv-preset #7370

Are you sure you want to change the base?

import unenv-preset #7370

Conversation

vicb commented Nov 27, 2024 • edited Loading

changeset-bot bot commented Nov 27, 2024 • edited Loading

⚠️ No Changeset found

pi0 Nov 27, 2024

Choose a reason for hiding this comment

pi0 Nov 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2024 • edited Loading

pi0 commented Nov 28, 2024

vicb commented Nov 29, 2024

petebacondarwin left a comment

Choose a reason for hiding this comment

petebacondarwin commented Dec 11, 2024

petebacondarwin commented Dec 11, 2024

petebacondarwin Dec 11, 2024

Choose a reason for hiding this comment

petebacondarwin commented Dec 11, 2024

vicb commented Nov 27, 2024 •

edited

Loading

changeset-bot bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading