-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide experimental flags to the defineCommand handler #7455
Conversation
|
1126d8c
to
0e4312a
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-wrangler-7455 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7455/npm-package-wrangler-7455 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-wrangler-7455 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-create-cloudflare-7455 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-kv-asset-handler-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-miniflare-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-pages-shared-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-vitest-pool-workers-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workers-editor-shared-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workers-shared-7455 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workflows-shared-7455 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change. Maybe we can go further in the future and remove ALS entirely, as it adds an extra layer of complexity and it's usually unnecessary, making the execution flow harder to understand.
currently, in order to access experimental flags you have to wrap each command handler in an AsyncLocalStorage context. this adds wraps it around the defineCommand handler so eventually the flags will be available to all commands.