Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide experimental flags to the defineCommand handler #7455

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Dec 5, 2024

currently, in order to access experimental flags you have to wrap each command handler in an AsyncLocalStorage context. this adds wraps it around the defineCommand handler so eventually the flags will be available to all commands.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: I think not breaking existing tests that use experimental flags should be sufficient?
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal helper

@emily-shen emily-shen requested a review from a team as a code owner December 5, 2024 14:33
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: b842643

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added no-changeset-required e2e Run e2e tests on a PR labels Dec 5, 2024
@emily-shen emily-shen force-pushed the emily/x-flags-define-cmd branch from 1126d8c to 0e4312a Compare December 6, 2024 09:45
Copy link
Contributor

github-actions bot commented Dec 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-wrangler-7455

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7455/npm-package-wrangler-7455

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-wrangler-7455 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-create-cloudflare-7455 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-kv-asset-handler-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-miniflare-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-pages-shared-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-vitest-pool-workers-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workers-editor-shared-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workers-shared-7455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12262257807/npm-package-cloudflare-workflows-shared-7455

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. Maybe we can go further in the future and remove ALS entirely, as it adds an extra layer of complexity and it's usually unnecessary, making the execution flow harder to understand.

@emily-shen emily-shen merged commit fa5a8fc into main Dec 11, 2024
31 checks passed
@emily-shen emily-shen deleted the emily/x-flags-define-cmd branch December 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants