Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate unused D1 commands/options #7471

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Dec 6, 2024

Fixes #7470

This PR:

  • removes any alpha-specific code paths from the d1 commands
  • removes --batch-size from wrangler d1 execute (long deprecated and not needed)
  • removes --batch-size from wrangler d1 migrations (long deprecated and not needed)
  • removes wrangler d1 backups commands (unsupported by production DBs, alpha dbs are deprecated)

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Public documentation

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 5bb4864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-wrangler-7471

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7471/npm-package-wrangler-7471

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-wrangler-7471 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-create-cloudflare-7471 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-kv-asset-handler-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-miniflare-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-pages-shared-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-vitest-pool-workers-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-workers-editor-shared-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-workers-shared-7471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12260483276/npm-package-cloudflare-workflows-shared-7471

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@rozenmd rozenmd force-pushed the rozenmd/deprecate-d1-commands-2 branch 2 times, most recently from ca5d843 to 91b99c9 Compare December 6, 2024 09:46
@rozenmd rozenmd force-pushed the rozenmd/deprecate-d1-commands-2 branch from 62313de to 2555637 Compare December 9, 2024 12:54
@rozenmd rozenmd marked this pull request as ready for review December 10, 2024 16:43
@rozenmd rozenmd requested review from a team as code owners December 10, 2024 16:43
@rozenmd rozenmd changed the title WIP - deprecate unused D1 commands/options deprecate unused D1 commands/options Dec 10, 2024
@rozenmd rozenmd merged commit dc669c4 into next Dec 10, 2024
30 of 33 checks passed
@rozenmd rozenmd deleted the rozenmd/deprecate-d1-commands-2 branch December 10, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants