Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: fix getting a workflow when such workflow was not yet created #7520

Conversation

bruxodasilva
Copy link
Contributor

@bruxodasilva bruxodasilva commented Dec 11, 2024

Fixes WOR-440.

Fixed a bug in local development where fetching a Workflow instance by ID would return a Workflow status, even if that instance did not exist. This only impacted the get() method on the Worker bindings.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: workflows does not have them
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@bruxodasilva bruxodasilva requested a review from a team as a code owner December 11, 2024 13:30
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: e210366

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workflows-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 11, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-wrangler-7520

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7520/npm-package-wrangler-7520

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-wrangler-7520 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-create-cloudflare-7520 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-kv-asset-handler-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-miniflare-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-pages-shared-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-vitest-pool-workers-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-workers-editor-shared-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-workers-shared-7520
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12279293110/npm-package-cloudflare-workflows-shared-7520

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Skye-31 Skye-31 merged commit 805ad2b into cloudflare:main Dec 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants