Add appGUID attribute to droplet resource [main] #2932
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
PR on v8 branch : 2933 |
3 tasks
gmllt
force-pushed
the
add-droplets-relationships-main
branch
from
edb7507
to
0d0ada0
Compare
gmllt
changed the title
Comment on lines
+44
to
+54
| type Data struct { | ||
| GUID string `json:"guid,omitempty"` | ||
| } | ||
|
|
||
| type RelationshipData struct { | ||
| Data Data `json:"data,omitempty"` | ||
| } | ||
|
|
||
| type Relationships struct { | ||
| App RelationshipData `json:"app,omitempty"` | ||
| } |
There was a problem hiding this comment.
Any particular reason for the difference between these structs and the ones for the unmarshal (named structs vs anonymous structs)? My suggestion is if we are keeping these inside functions personally I would prefer to have them anonymous.
There was a problem hiding this comment.
@gmllt wanted to follow up. Do you have any feedback on this?
gmllt
force-pushed
the
add-droplets-relationships-main
branch
from
0d0ada0
to
629e8a1
Compare
a-b
force-pushed
the
add-droplets-relationships-main
branch
from
629e8a1
to
6ee45ec
Compare
weresch
force-pushed
the
add-droplets-relationships-main
branch
from
6ee45ec
to
a28ccbd
Compare
|
@dependabot rebase |
a-b
changed the title
a-b
force-pushed
the
add-droplets-relationships-main
branch
from
a28ccbd
to
05b3910
Compare
a-b
force-pushed
the
add-droplets-relationships-main
branch
from
05b3910
to
ac24a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where this PR should be backported?
Description of the Change
The V3 API allows you to access to the relationships existing beween a droplet and its related app.
This PR make this relationship visible trough a new
AppGUIDattribute in the resourcedroplet.The community
cf_exportercurrently use the/v2/spaces/:guid/summaryendpoint to gain access to buildpack associated to an application. Have this relationship visible would help get rid of calls on this endpoint and retrieve buildpacks attached to an application through its droplets.This feature is necessary for applications using the cli product in go development to established relationship between an
applicationresource and its droplets.This feature will not cause breaking change.